Line 82: |
Line 82: |
| * Ensure that the changelog version really matches the RPM version. | | * Ensure that the changelog version really matches the RPM version. |
| * Check if the spec file correct, look at the changes | | * Check if the spec file correct, look at the changes |
| + | * There must be a bugzilla number in this format [SME: 7129] |
| + | * Is the date really correct? Both day and date. |
| + | * The version should follow after the email address |
| | | |
| ==== Applying the patch ==== | | ==== Applying the patch ==== |
| To apply the new patch on the CVS tree/code issue the following command: | | To apply the new patch on the CVS tree/code issue the following command: |
| cvs diff e-smith-base.spec | | cvs diff e-smith-base.spec |
− |
| |
− | * Have you updated the release? Is that new release in the changelog?
| |
− | * Have you included the patch, Patch55: e-smith-proftpd-2.2.0-persistent_passwd.patch
| |
− | * Is the changelog correct
| |
− |
| |
− | <pre>
| |
− | * Tue Jan 22 2013 Ian Wells <esmith@wellsi.com> 2.2.0-4.sme
| |
− | - Remove previous change [SME: 7129]
| |
− | </pre>
| |
− |
| |
− | * There must be a bugzilla number in this format [SME: 7129]
| |
− | * Is the date really correct? Both day and date.
| |
− | * The version should follow after the email address
| |
− |
| |
− | CHECK: what would be committed
| |
| | | |
| ==== Update CVS ==== | | ==== Update CVS ==== |
Line 112: |
Line 100: |
| * ? egregious file not part of CVS record for this dir | | * ? egregious file not part of CVS record for this dir |
| | | |
− | CHECK: has the patch files been added? cvs add e-smith-quota-2.0.0-badlyformattedie8.patch
| + | * Ensure that the patch file has been added cvs add e-smith-base-5.2.0-test.patch |
− | | + | * Ensure that your patch/files etc. are UNIX style or do they have DOS endings (bad) |
− | CHECK: are the files UNIX or do they have DOS endings (bad)
| |
| | | |
| ==== Build a test RPM ==== | | ==== Build a test RPM ==== |