Changes

{{Incomplete}}

{{Incomplete}}

==Goal==

==Goal==

This page is meant to provide information on the Development Review process for Howto's and Contribs. The goal of this is to improve the quality of Howto's and Contribs and provide safe instructions and contribs that can be installed on production systems.

This page is meant to provide information on the Development Review process for Howto's and Contribs. The goal of this is to improve the quality of Howto's and Contribs and provide safe instructions and contribs that can be installed on production systems. A list of pages marked for review can be found in the [[:Category:Needs review]].

==Review points==

==Review points==

===Contribs===

===Contribs===

{{Tip box|msg=Please make sure you have read and understood the information in the [[:SME_Server:Documentation:Developers_Manual SME Server Developer's Guide]], if you have questions please subscribe to the [http://lists.contribs.org/mailman/listinfo/devinfo Development Information mailing list] and ask your questions there.}}

{{Tip box|msg=Please make sure you have read and understood the information in the [[:SME_Server:Documentation:Developers_Manual | SME Server Developer's Guide]], if you have questions please subscribe to the [http://lists.contribs.org/mailman/listinfo/devinfo Development Information mailing list] and ask your questions there.}}

To make sure that contribs are save to install for all users packages are reviews on a list of points.

To make sure that contribs are save to install for all users packages are reviews on a list of points.

====No binary content====

====No binary content====

SME Server has approved the use of a few repositories for this purpose, those are RPMForge (Dag, Dries and ATrpms), Fedora EPEL and Centos repositories.

SME Server has approved the use of a few repositories for this purpose, those are RPMForge (Dag, Dries and ATrpms), Fedora EPEL and Centos repositories.

====<tt>%pre</tt> and <tt>%post</tt> macros====

====<tt>%pre</tt> and <tt>%post</tt> macros====

The package should not contain any <tt>%post</tt> and <tt>%postun</tt> macros and should make minimal use of <tt>%pre</tt> and <tt>%preun</tt> scripts. Most of the instructions usually written in those sections can be implemented using a better, more robust way. Developers please have a look at the [[:SME_Server:Documentation:Developers_Manual SME Server Developer's Guide]] and if still unclear feel free to ask on the [http://lists.contribs.org/mailman/listinfo/devinfo Development Information mailing list].

The package should not contain any <tt>%post</tt> and <tt>%postun</tt> macros and should make minimal use of <tt>%pre</tt> and <tt>%preun</tt> scripts. Most of the instructions usually written in those sections can be implemented using a better, more robust way. Developers please have a look at the [[:SME_Server:Documentation:Developers_Manual | SME Server Developer's Guide]] and if still unclear feel free to ask on the [http://lists.contribs.org/mailman/listinfo/devinfo Development Information mailing list].

====Removal of files====

====Removal of files====

All files in a contrib should be owned by that contrib and included in the package. As the installer takes care of removing those files contrib authors should not need to add removal instructions to the macro sections of the SPEC file.

All files in a contrib should be owned by that contrib and included in the package. As the installer takes care of removing those files contrib authors should not need to add removal instructions to the macro sections of the SPEC file.