Changes

Jump to navigation Jump to search
2,853 bytes removed ,  14:01, 8 November 2007
cleanup - correct if I misunderstood something!
Line 1: Line 1: −
=ipdiscover bug=
+
=known bugs=
 +
There are still some bugs in this RPM... Help us to fix them!
 +
==ipdiscover bug==
 
We need to confirm that ipdiscover works when the smeserver is the forced client.
 
We need to confirm that ipdiscover works when the smeserver is the forced client.
   Line 18: Line 20:  
Cool34000
 
Cool34000
 
----
 
----
=deployment=
+
==deployment deletion bug==
==deletion bug==
   
When you delete a package, ocs complains, but it deletes the files anyway, document later
 
When you delete a package, ocs complains, but it deletes the files anyway, document later
   Line 38: Line 39:  
stephen
 
stephen
 
----
 
----
 
+
=future RPM=
==Upload size limit==
+
What will be fixed in next RPM release...
Must document that on the Wiki:
+
==upload size limit==
 
  Max allowed packet value is locked at 10M by default on SME.
 
  Max allowed packet value is locked at 10M by default on SME.
 +
Let's delete the mysql custom-template in the future RPM!
   −
No need to create a custom template: DB values already exist for this! They are hidden in php.ini templates ''40DataHandling'' and ''60FileUploads''
+
We can modify this value to only affect the ocs directory.
 
+
What is the impact of setting large values on the server?
+
Add the following lines to Apache template:
 
+
  <Directory /opt/inventory/ocs/ocsreports>
 
+
  ..
php Values can be changed with the following:
  −
  config setprop php UploadMaxFilesize 50M PostMaxSize 50M
  −
expand-template /etc/php.ini
  −
  signal-event ocsglpi-update
  −
 
  −
I will add php.ini to the list of templates2expand
  −
 
  −
Let's delete the mysql custom-template in the RPM and document how to change both values to allow uploading larger files!
  −
 
  −
 
  −
 
  −
Cool34000
  −
----
  −
I think you should restrict the affect to just the ocs directory
  −
 
  −
config setprop ocs MaxUpload 50M
   
  php_admin_value post_max_size $ocs{'MaxUpload'}
 
  php_admin_value post_max_size $ocs{'MaxUpload'}
 
  php_admin_value upload_max_filesize $ocs{'MaxUpload'}
 
  php_admin_value upload_max_filesize $ocs{'MaxUpload'}
 +
Apply changes:
 +
config setprop ocs MaxUpload 50M
 
  expand-template /etc/httpd/conf/httpd.conf
 
  expand-template /etc/httpd/conf/httpd.conf
 
  /etc/init.d/httpd-e-smith condrestart
 
  /etc/init.d/httpd-e-smith condrestart
   −
$ocs{'MaxUpload'} default = 10M
+
==aliases==
 
  −
yes delete /etc/e-smith/templates-custom/etc/my.cnf/005mysqld
  −
 
  −
stephen
  −
----
  −
 
  −
 
  −
you have to set a db value anyway so you may as well add it to the ocs fragment
  −
 
  −
----
  −
Yes, I tried to limit changes to ocs in the template, but it didn't worked for me.
  −
 
  −
Maybe I was missing this line:
  −
/etc/init.d/httpd-e-smith condrestart
  −
 
  −
Testing this now, of course it would be better to limit these values only for ocs!
  −
 
  −
=> Still doesn't work... Values are expanded but can't upload file >10M... Looks like this value must be global.
  −
 
  −
Here's the non working template:
  −
#--------------------------------------------------------------
  −
# OCS Inventory Next Generation
  −
#--------------------------------------------------------------
  −
Alias /download /opt/inventory/ocs/download
  −
Alias /ocs      /opt/inventory/ocs/ocsreports
  −
+{
  −
+    if (exists $ocs{'URL'})
  −
+      { $OUT .= "Alias  /$ocs{'URL'} /opt/inventory/ocs/ocsreports"; }
  −
+}
  −
  −
<Directory /opt/inventory/ocs/download>
  −
  Options None
  −
  Options +Indexes
  −
  Options +Includes
  −
  AllowOverride None
  −
  order deny,allow
  −
  deny from all
  −
  allow from { $localAccess }
  −
  php_admin_value open_basedir /opt/inventory/ocs/download:/tmp
  −
+  php_admin_value post_max_size $ocs{'MaxUpload'}
  −
+  php_admin_value upload_max_filesize $ocs{'MaxUpload'}
  −
</Directory>
  −
 
  −
config setprop ocs MaxUpload 50M
  −
signal-event ocsglpi-update
  −
/etc/init.d/httpd-e-smith condrestart
  −
 
  −
Cool34000
  −
----
  −
 
  −
not download, change ocsreports [we don't upload from /download]
  −
<Directory /opt/inventory/ocs/ocsreports>
  −
 
  −
Stefen
  −
----
  −
How stupid am I? Thanks for the fix!
  −
 
  −
Cool34000
  −
----
  −
 
  −
=aliases=
   
Future RPM will allow to add aliases using 'URL' value to ocs and glpi
 
Future RPM will allow to add aliases using 'URL' value to ocs and glpi
 
  {
 
  {
Line 137: Line 64:  
  }
 
  }
   −
=rpm changes=
+
==RPM is not a chatroom==
 
+
Less chat in the install output, just say look at the wiki page, + renamed wiki page
for your consideration
  −
 
  −
split help file out into separate rpm to save redownloading
  −
use rm -f root/path/to/help in the spec file
  −
no need to touch the ocs.tar.qz
  −
 
  −
less chat in the install output, just say look at the wiki page, + renamed wiki page
  −
 
  −
don't use signal-event my-own-event
  −
charlie doesn't want new events created, so we obey, (mostly)
  −
just give all the commands, or use an existing one, we could use domain-modify
  −
 
  −
stephen
  −
----
  −
Thanks for these comments... I didn't know that we should not use events functions for our own events. Any chance to have an explanation? This sounds very weird to me (but there must be some reasons!)
     −
Anyway, I will use domain-modify to expand all templates... I will try to (mostly) obey ;-)
+
==events==
 +
Don't use signal-event my-own-event: just give all the commands, or use an existing one, we could use domain-modify
   −
Here's the actual createlinks perl script:
+
Here's the future createlinks perl script, this is just all we need, I will remove the ones already in place in ''domain-modify'' (i.e. apache should already be expanded+restarted):
 
  #!/usr/bin/perl -w
 
  #!/usr/bin/perl -w
 
  use esmith::Build::CreateLinks qw(:all);
 
  use esmith::Build::CreateLinks qw(:all);
 
   
 
   
 
  # Templates to adjust
 
  # Templates to adjust
  templates2events("/etc/e-smith/sql/init/80ocs_mysql.sql",          qw(ocsglpi-update post-upgrade ));
+
  templates2events("/etc/e-smith/sql/init/80ocs_mysql.sql",          qw(domain-modify post-upgrade ));
  templates2events("/etc/e-smith/sql/init/82glpi_mysql.sql",        qw(ocsglpi-update post-upgrade ));
+
  templates2events("/etc/e-smith/sql/init/82glpi_mysql.sql",        qw(domain-modify post-upgrade ));
  templates2events("/etc/e-smith/sql/init/84ocs-glpi.sql",          qw(ocsglpi-update post-upgrade ));
+
  templates2events("/etc/e-smith/sql/init/84ocs-glpi.sql",          qw(domain-modify post-upgrade ));
  templates2events("/etc/httpd/conf/httpd.conf",                    qw(ocsglpi-update post-upgrade ));
+
  templates2events("/etc/httpd/conf/httpd.conf",                    qw(domain-modify post-upgrade ));
  templates2events("/etc/ocsinventory-agent/ocsinv.conf",            qw(ocsglpi-update post-upgrade ));
+
  templates2events("/etc/ocsinventory-agent/ocsinv.conf",            qw(domain-modify post-upgrade ));
templates2events("/etc/php.ini",                                  qw(ocsglpi-update post-upgrade ));
+
  templates2events("/opt/inventory/glpi/config/config_db.php",      qw(domain-modify post-upgrade ));
  templates2events("/opt/inventory/glpi/config/config_db.php",      qw(ocsglpi-update post-upgrade ));
+
  templates2events("/opt/inventory/ocs/ocsreports/dbconfig.inc.php", qw(domain-modify post-upgrade ));
  templates2events("/opt/inventory/ocs/ocsreports/dbconfig.inc.php", qw(ocsglpi-update post-upgrade ));
   
  # Services to restart
 
  # Services to restart
 
  safe_symlink("restart", "root/etc/e-smith/events/ocsglpi-update/services2adjust/httpd-e-smith");
 
  safe_symlink("restart", "root/etc/e-smith/events/ocsglpi-update/services2adjust/httpd-e-smith");
 
  safe_symlink("start",  "root/etc/e-smith/events/ocsglpi-update/services2adjust/mysql.init");
 
  safe_symlink("start",  "root/etc/e-smith/events/ocsglpi-update/services2adjust/mysql.init");
As you can see, there's a loooong list as all is templated!
  −
  −
  −
I will also delete all chat in the RPM. That's an old habits of mine...
  −
  −
About the help file, I remember reading that it must be placed into www/ocs/files/guide.pdf (else I would have put this file in /usr/share/doc/) so we cannot delete this file from the RPM :'(
      +
==save bandwidth==
 +
Create a seperate RPM with the ''guide.pdf'' and make it a dependency of the main RPM. No need to touch the ocs.tar.qz
   −
----
+
==MySQL init scripts ==
 
  /etc/e-smith/sql/init/* should only be used one to create the db table, then it is deleted
 
  /etc/e-smith/sql/init/* should only be used one to create the db table, then it is deleted
 
  httpd.conf and php.ini are in standard events (and are we still changing php.ini?)
 
  httpd.conf and php.ini are in standard events (and are we still changing php.ini?)
 
  which only leaves three fragments to document in the rare case that something changes
 
  which only leaves three fragments to document in the rare case that something changes
  −
so here we don't really need the event,
  −
a little documentation will do (and you had to doc the new event anyway)
     −
+I'm looking at the src.rpm and it needs to work a different way before this will work, looking...
+
Stefen
++easiest way is to just delete the guide.pdf from the tar.gz, and build another rpm with just the pdf
  −
yes put the help file at www/ocs/files/guide.pdf
  −
just make a new rpm with only that file + make it a dependancy
  −
then you can delete it from the main rpm
  −
 
  −
+ok, you already have them, just need to check on a clean install what is available
  −
another thing to do in time is...
  −
add all the requires (to perl dependencies)  that are available from existing repos
  −
then you can reduce the number of perl rpm in your download
  −
the less you are responsible for the better
  −
 
  −
++ - ocsagent.exe is now included in ./ocs/files
  −
I'm not sure this is needed,
  −
lets delete it from the server and see if it affects anything before removing from the rpm
  −
it does generate a warning during the web installer but that is irrelevant to us (from dev in ocs forums)
  −
 
  −
stephen
   
----
 
----
 
Yes, all that goes in /etc/e-smith/sql/init/ is dropped after a successful importation. I know that, I use it this way:
 
Yes, all that goes in /etc/e-smith/sql/init/ is dropped after a successful importation. I know that, I use it this way:
Line 218: Line 106:  
Take a look on their name when all 5 files are put in /etc/e-smith/sql/init/ once expanded
 
Take a look on their name when all 5 files are put in /etc/e-smith/sql/init/ once expanded
    +
Cool3400
 +
----
 +
 +
==RPM strcuture==
 +
I'm looking at the src.rpm and it needs to work a different way before this will work, looking...
 +
stephen
 +
----
    +
==dependencies==
 +
OK, you already have them, just need to check on a clean install what is available
 +
 +
Another thing to do in time is to add all the requires (to perl dependencies) that are available from existing repos.
 +
 +
Then you can reduce the number of perl rpm in your download the less you are responsible for the better
 +
 +
stephen
 +
----
 +
 +
==ocsagent.exe==
 +
I'm not sure this is needed, lets delete it from the server and see if it affects anything before removing from the rpm
 +
it does generate a warning during the web installer but that is irrelevant to us (from dev in ocs forums)
 +
 +
stephen
 +
----
 
About ''ocsagent.exe'', it doesn't help you when you've installed the Agent, but if you use the standalone OCSLogon.exe to send inventories, the client will not download needed files. This file is needed!
 
About ''ocsagent.exe'', it doesn't help you when you've installed the Agent, but if you use the standalone OCSLogon.exe to send inventories, the client will not download needed files. This file is needed!
    +
By the way, we need to document that: next time the Agent version changes, this file needs to be upgraded too!
   −
OK for the doc new RPM... That's a good way to save bandwidth!
+
Cool34000
 +
----
498

edits

Navigation menu